Re: [PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-11-15 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 12, 2022 at 01:51:07PM -0400, Peter Xu wrote: >> On Wed, Oct 12, 2022 at 05:43:53PM +0100, Dr. David Alan Gilbert wrote: >> > * Peter Xu (pet...@redhat.com) wrote: >> > > Don't take the bitmap mutex when sending pages, or when being throttled >> > > by >> > > migrati

Re: [PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-13 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Oct 12, 2022 at 01:51:07PM -0400, Peter Xu wrote: > > On Wed, Oct 12, 2022 at 05:43:53PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Don't take the bitmap mutex when sending pages, or when being throttled

Re: [PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-13 Thread Peter Xu
On Wed, Oct 12, 2022 at 01:51:07PM -0400, Peter Xu wrote: > On Wed, Oct 12, 2022 at 05:43:53PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > Don't take the bitmap mutex when sending pages, or when being throttled by > > > migration_rate_limit() (which is a bit

Re: [PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-12 Thread Peter Xu
On Wed, Oct 12, 2022 at 05:43:53PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Don't take the bitmap mutex when sending pages, or when being throttled by > > migration_rate_limit() (which is a bit tricky to call it here in ram code, > > but seems still helpful).

Re: [PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Don't take the bitmap mutex when sending pages, or when being throttled by > migration_rate_limit() (which is a bit tricky to call it here in ram code, > but seems still helpful). > > It prepares for the possibility of concurrently sending pages in >1 thread

[PATCH v2 06/15] migration: Yield bitmap_mutex properly when sending/sleeping

2022-10-11 Thread Peter Xu
Don't take the bitmap mutex when sending pages, or when being throttled by migration_rate_limit() (which is a bit tricky to call it here in ram code, but seems still helpful). It prepares for the possibility of concurrently sending pages in >1 threads using the function ram_save_host_page() becaus