Re: [PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-06-05 Thread Fabiano Rosas
"Dr. David Alan Gilbert" writes: > * Fabiano Rosas (faro...@suse.de) wrote: >> Peter Xu writes: >> >> > On Thu, May 23, 2024 at 04:05:36PM -0300, Fabiano Rosas wrote: >> >> We've been up until now cleaning up any file descriptors that have >> >> been passed into QEMU and never duplicated[1,2].

Re: [PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-06-04 Thread Dr. David Alan Gilbert
* Fabiano Rosas (faro...@suse.de) wrote: > Peter Xu writes: > > > On Thu, May 23, 2024 at 04:05:36PM -0300, Fabiano Rosas wrote: > >> We've been up until now cleaning up any file descriptors that have > >> been passed into QEMU and never duplicated[1,2]. A file descriptor > >> without duplicates

Re: [PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-05-31 Thread Peter Xu
On Fri, May 31, 2024 at 12:25:52PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Thu, May 23, 2024 at 04:05:36PM -0300, Fabiano Rosas wrote: > >> We've been up until now cleaning up any file descriptors that have > >> been passed into QEMU and never duplicated[1,2]. A file descriptor >

Re: [PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-05-31 Thread Fabiano Rosas
Peter Xu writes: > On Thu, May 23, 2024 at 04:05:36PM -0300, Fabiano Rosas wrote: >> We've been up until now cleaning up any file descriptors that have >> been passed into QEMU and never duplicated[1,2]. A file descriptor >> without duplicates indicates that no part of QEMU has made use of >> it.

Re: [PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-05-30 Thread Peter Xu
On Thu, May 23, 2024 at 04:05:36PM -0300, Fabiano Rosas wrote: > We've been up until now cleaning up any file descriptors that have > been passed into QEMU and never duplicated[1,2]. A file descriptor > without duplicates indicates that no part of QEMU has made use of > it. This approach is startin

[PATCH v2 06/18] monitor: Stop removing non-duplicated fds

2024-05-23 Thread Fabiano Rosas
We've been up until now cleaning up any file descriptors that have been passed into QEMU and never duplicated[1,2]. A file descriptor without duplicates indicates that no part of QEMU has made use of it. This approach is starting to show some cracks now that we're starting to consume fds from the m