Re: [PATCH v2 06/42] i386: Add CHECK_NO_VEX

2022-04-25 Thread Richard Henderson
On 4/24/22 15:01, Paul Brook wrote: +/* VEX prefix not allowed */ +#define CHECK_NO_VEX(s) do { \ +if (s->prefix & PREFIX_VEX) \ +goto illegal_op; \ +} while (0) Make the do/while align, and add the required braces for the if, per coding style. r~

Re: [PATCH v2 06/42] i386: Add CHECK_NO_VEX

2022-04-25 Thread Richard Henderson
On 4/24/22 15:01, Paul Brook wrote: Reject invalid VEX encodings on MMX instructions. Signed-off-by: Paul Brook --- target/i386/tcg/translate.c | 26 ++ 1 file changed, 26 insertions(+) Reviewed-by: Richard Henderson r~

[PATCH v2 06/42] i386: Add CHECK_NO_VEX

2022-04-24 Thread Paul Brook
Reject invalid VEX encodings on MMX instructions. Signed-off-by: Paul Brook --- target/i386/tcg/translate.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/target/i386/tcg/translate.c b/target/i386/tcg/translate.c index 5335b86c01..66ba690b7d 100644 --- a/target/i