Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-03 Thread Philippe Mathieu-Daudé
On 7/3/21 4:16 PM, Mark Cave-Ayland wrote: > On 03/07/2021 14:10, Philippe Mathieu-Daudé wrote: >> On 7/3/21 2:04 PM, Mark Cave-Ayland wrote: >>> I've tested this under Linux/m68k, NetBSD/arc and MacOS and networking >>> seems fine after a quick test in each OS. The slight curiosity is that >>> th

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-03 Thread Mark Cave-Ayland
On 03/07/2021 14:10, Philippe Mathieu-Daudé wrote: On 7/3/21 2:04 PM, Mark Cave-Ayland wrote: On 03/07/2021 09:52, Philippe Mathieu-Daudé wrote: On 7/3/21 8:21 AM, Mark Cave-Ayland wrote: On 02/07/2021 05:36, Finn Thain wrote: On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: Commit 3fe9a838ec "

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-03 Thread Philippe Mathieu-Daudé
On 7/3/21 2:04 PM, Mark Cave-Ayland wrote: > On 03/07/2021 09:52, Philippe Mathieu-Daudé wrote: >> On 7/3/21 8:21 AM, Mark Cave-Ayland wrote: >>> On 02/07/2021 05:36, Finn Thain wrote: >>> > On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: >> Commit 3fe9a838ec "dp8393x: Always use 32-bit accesse

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-03 Thread Mark Cave-Ayland
On 03/07/2021 09:52, Philippe Mathieu-Daudé wrote: On 7/3/21 8:21 AM, Mark Cave-Ayland wrote: On 02/07/2021 05:36, Finn Thain wrote: On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit No

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-03 Thread Philippe Mathieu-Daudé
On 7/3/21 8:21 AM, Mark Cave-Ayland wrote: > On 02/07/2021 05:36, Finn Thain wrote: > >>> On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit >> >> No, that assumption was not made ther

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-02 Thread Mark Cave-Ayland
On 02/07/2021 05:36, Finn Thain wrote: On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit No, that assumption was not made there. Just take a look at my commits in Linux that make 16-bit ac

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-01 Thread Finn Thain
On Thu, 1 Jul 2021, Philippe Mathieu-Daudé wrote: > On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: > > Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that > > all accesses to the registers were 32-bit No, that assumption was not made there. Just take a look at my commits in Linux

Re: [PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-07-01 Thread Philippe Mathieu-Daudé
On 6/25/21 8:53 AM, Mark Cave-Ayland wrote: > Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all > accesses > to the registers were 32-bit but this is actually not the case. The access > size is > determined by the CPU instruction used and not the number of physical address

[PATCH v2 08/10] dp8393x: don't force 32-bit register access

2021-06-25 Thread Mark Cave-Ayland
Commit 3fe9a838ec "dp8393x: Always use 32-bit accesses" assumed that all accesses to the registers were 32-bit but this is actually not the case. The access size is determined by the CPU instruction used and not the number of physical address lines. The big_endian workaround applied to the regi