Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-08 Thread Daniel Henrique Barboza
On 6/7/22 03:44, Cédric Le Goater wrote: Also, the comment seems wrong to me. The qom parenting doesn't matter when building the device tree. it does. See pnv_dt_xscom() And this is the root cause of many headaches for user-created devices. Could it be done differently ? Just tried to do

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Frederic Barrat
On 07/06/2022 08:35, Cédric Le Goater wrote: Also, the comment seems wrong to me. The qom parenting doesn't matter when building the device tree. it does. See pnv_dt_xscom() Yeah, what I meant is that on P9, there's no "dt_scom" method for the PHB. The PHBs are added by the dt_scom()

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-07 Thread Frederic Barrat
On 03/06/2022 23:00, Daniel Henrique Barboza wrote:   static void pnv_phb4_realize(DeviceState *dev, Error **errp)   {   PnvPHB4 *phb = PNV_PHB4(dev); +    PnvMachineState *pnv = PNV_MACHINE(qdev_get_machine()); +    PnvChip *chip = pnv_get_chip(pnv, phb->chip_id);   XiveSource *xsrc =

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-06 Thread Cédric Le Goater
Also, the comment seems wrong to me. The qom parenting doesn't matter when building the device tree. it does. See pnv_dt_xscom() And this is the root cause of many headaches for user-created devices. Could it be done differently ? Thanks, C.

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-06 Thread Cédric Le Goater
On 6/3/22 23:00, Daniel Henrique Barboza wrote: On 6/2/22 13:33, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: To enable user creatable PnvPHB devices for powernv9 we'll revert the powernv9 related changes made in 9c10d86fee "ppc/pnv: Remove user-created PHB{3,4

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-03 Thread Daniel Henrique Barboza
On 6/2/22 13:33, Frederic Barrat wrote: On 31/05/2022 23:49, Daniel Henrique Barboza wrote: To enable user creatable PnvPHB devices for powernv9 we'll revert the powernv9 related changes made in 9c10d86fee "ppc/pnv: Remove user-created PHB{3,4,5} devices". This change alone isn't enough to

Re: [PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-06-02 Thread Frederic Barrat
On 31/05/2022 23:49, Daniel Henrique Barboza wrote: To enable user creatable PnvPHB devices for powernv9 we'll revert the powernv9 related changes made in 9c10d86fee "ppc/pnv: Remove user-created PHB{3,4,5} devices". This change alone isn't enough to enable user creatable devices for powernv1

[PATCH v2 08/16] ppc/pnv: user created pnv-phb for powernv9

2022-05-31 Thread Daniel Henrique Barboza
To enable user creatable PnvPHB devices for powernv9 we'll revert the powernv9 related changes made in 9c10d86fee "ppc/pnv: Remove user-created PHB{3,4,5} devices". This change alone isn't enough to enable user creatable devices for powernv10 due to how pnv_phb4_get_pec() currently works. For now