Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-07-01 Thread Cédric Le Goater
> Thanks for the new device. It helps me see where to expand on PMBus. Thanks for adding the whole pmbus infrastructure! It’s really useful. And thanks for the review. Off-topic, but I’ve been meaning to reach out to you guys (Google engineers working on QEMU for OpenBMC)

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-30 Thread Patrick Venture
On Wed, Jun 29, 2022 at 11:34 AM Peter Delevoryas wrote: > > > > On Jun 29, 2022, at 11:04 AM, Titus Rwantare wrote: > > > > On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas > > wrote: > >> > >> Signed-off-by: Peter Delevoryas > >> --- > > > >> --- a/hw/i2c/pmbus_device.c > >> +++

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-29 Thread Peter Delevoryas
> On Jun 29, 2022, at 11:04 AM, Titus Rwantare wrote: > > On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas > wrote: >> >> Signed-off-by: Peter Delevoryas >> --- > >> --- a/hw/i2c/pmbus_device.c >> +++ b/hw/i2c/pmbus_device.c >> @@ -984,6 +984,11 @@ static uint8_t

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-29 Thread Titus Rwantare
On Tue, 28 Jun 2022 at 20:36, Peter Delevoryas wrote: > > Signed-off-by: Peter Delevoryas > --- > --- a/hw/i2c/pmbus_device.c > +++ b/hw/i2c/pmbus_device.c > @@ -984,6 +984,11 @@ static uint8_t pmbus_receive_byte(SMBusDevice *smd) > } > break; > > +case PMBUS_IC_DEVICE_ID:

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-29 Thread Peter Delevoryas
> On Jun 29, 2022, at 1:40 AM, Cédric Le Goater wrote: > > On 6/29/22 05:36, Peter Delevoryas wrote: >> Signed-off-by: Peter Delevoryas > > This is also adding a "Renesas ISL69259 Digital Multiphase Voltage > Regulator" device. There should be 2 patches. H yes definitely, I’ll fix this.

Re: [PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-29 Thread Cédric Le Goater
On 6/29/22 05:36, Peter Delevoryas wrote: Signed-off-by: Peter Delevoryas This is also adding a "Renesas ISL69259 Digital Multiphase Voltage Regulator" device. There should be 2 patches. Thanks, C. --- hw/i2c/pmbus_device.c| 5 + hw/sensor/isl_pmbus_vr.c | 31

[PATCH v2 09/13] hw/i2c/pmbus: Add read-only IC_DEVICE_ID support

2022-06-28 Thread Peter Delevoryas
Signed-off-by: Peter Delevoryas --- hw/i2c/pmbus_device.c| 5 + hw/sensor/isl_pmbus_vr.c | 31 +++ include/hw/i2c/pmbus_device.h| 1 + include/hw/sensor/isl_pmbus_vr.h | 1 + 4 files changed, 38 insertions(+) diff --git