Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-09 Thread Juan Quintela
Li Zhang wrote: > When doing live migration with multifd channels 8, 16 or larger number, > the guest hangs in the presence of the network errors such as missing TCP > ACKs. > > At sender's side: > The main thread is blocked on qemu_thread_join, migration_fd_cleanup > is called because one

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-07 Thread Li Zhang
On 12/6/21 8:50 PM, Dr. David Alan Gilbert wrote: * Li Zhang (lizh...@suse.de) wrote: Thanks for Daniel's review. Hi David and Juan, Any comments for this patch? Yeh I think that's OK, so Reviewed-by: Dr. David Alan Gilbert I'd have a slight preference for it being before the post I

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-06 Thread Dr. David Alan Gilbert
* Li Zhang (lizh...@suse.de) wrote: > > Thanks for Daniel's review. > > Hi David and Juan, > > Any comments for this patch? > Yeh I think that's OK, so Reviewed-by: Dr. David Alan Gilbert I'd have a slight preference for it being before the post I think. Dave > > Thanks > > Li > > On

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-06 Thread Li Zhang
Thanks for Daniel's review. Hi David and Juan, Any comments for this patch? Thanks Li On 12/3/21 12:55 PM, Li Zhang wrote: When doing live migration with multifd channels 8, 16 or larger number, the guest hangs in the presence of the network errors such as missing TCP ACKs. At sender's

Re: [PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-03 Thread Daniel P . Berrangé
On Fri, Dec 03, 2021 at 12:55:33PM +0100, Li Zhang wrote: > When doing live migration with multifd channels 8, 16 or larger number, > the guest hangs in the presence of the network errors such as missing TCP > ACKs. > > At sender's side: > The main thread is blocked on qemu_thread_join,

[PATCH v2 1/1] multifd: Shut down the QIO channels to avoid blocking the send threads when they are terminated.

2021-12-03 Thread Li Zhang
When doing live migration with multifd channels 8, 16 or larger number, the guest hangs in the presence of the network errors such as missing TCP ACKs. At sender's side: The main thread is blocked on qemu_thread_join, migration_fd_cleanup is called because one thread fails on