Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-22 Thread Markus Armbruster
Thomas Huth writes: > On 22/03/2023 10.28, Daniel P. Berrangé wrote: >> On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote: >>> Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto: >>> Would it make sense to add it e.g. to "-action" instead, i.e. something like "-action

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-22 Thread Thomas Huth
On 22/03/2023 10.28, Daniel P. Berrangé wrote: On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote: Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto: Would it make sense to add it e.g. to "-action" instead, i.e. something like "-action teardown=async" ? -action is just a wrapper

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-22 Thread Daniel P . Berrangé
On Tue, Mar 21, 2023 at 09:47:57PM +0100, Paolo Bonzini wrote: > Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto: > > > Would it make sense to add it e.g. to "-action" instead, i.e. something > > like > > "-action teardown=async" ? > > > > -action is just a wrapper for the action-set QMP

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-21 Thread Paolo Bonzini
Il lun 20 mar 2023, 16:42 Thomas Huth ha scritto: > Would it make sense to add it e.g. to "-action" instead, i.e. something > like > "-action teardown=async" ? > -action is just a wrapper for the action-set QMP command. I don't think it fits very well; its arguments are only guest actions while

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
On Mon, 20 Mar 2023 17:05:07 +0100 Markus Armbruster wrote: > Thomas Huth writes: > > > On 20/03/2023 16.31, Markus Armbruster wrote: > >> Claudio Imbrenda writes: > >> > >>> The recently introduced -async-teardown commandline option was not > >>> wired up properly and did not show up in

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Markus Armbruster
Thomas Huth writes: > On 20/03/2023 16.31, Markus Armbruster wrote: >> Claudio Imbrenda writes: >> >>> The recently introduced -async-teardown commandline option was not >>> wired up properly and did not show up in the output of the QMP command >>> query-command-line-options. This means that

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Thomas Huth
On 20/03/2023 16.31, Markus Armbruster wrote: Claudio Imbrenda writes: The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover

Re: [PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Markus Armbruster
Claudio Imbrenda writes: > The recently introduced -async-teardown commandline option was not > wired up properly and did not show up in the output of the QMP command > query-command-line-options. This means that libvirt will have no way to > discover whether the feature is supported. There was

[PATCH v2 1/1] util/async-teardown: wire up query-command-line-options

2023-03-20 Thread Claudio Imbrenda
The recently introduced -async-teardown commandline option was not wired up properly and did not show up in the output of the QMP command query-command-line-options. This means that libvirt will have no way to discover whether the feature is supported. This patch fixes the issue by correctly