Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

2021-11-03 Thread Eugenio Perez Martin
On Wed, Nov 3, 2021 at 3:50 AM Jason Wang wrote: > > On Tue, Nov 2, 2021 at 7:41 PM Eugenio Pérez wrote: > > > > The -1 assumes that all devices with no cvq have an spare vq allocated > > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid > > device by the standard, so just s

Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Jason Wang
On Tue, Nov 2, 2021 at 7:41 PM Eugenio Pérez wrote: > > The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid > device by the standard, so just stick to the right number of device > models. > > This is not a

Re: [PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Juan Quintela
Eugenio Pérez wrote: Y> The -1 assumes that all devices with no cvq have an spare vq allocated > for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid > device by the standard, so just stick to the right number of device > models. > > This is not a problem to vhost-net, but it is

[PATCH v2 1/1] vhost: Fix last queue index of devices with no cvq

2021-11-02 Thread Eugenio Pérez
The -1 assumes that all devices with no cvq have an spare vq allocated for them, but with no offer of VIRTIO_NET_F_CTRL_VQ. This is an invalid device by the standard, so just stick to the right number of device models. This is not a problem to vhost-net, but it is to vhost-vdpa, which device model