Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-02-09 Thread Troy Lee
Hi Joel, On Tue, Feb 8, 2022 at 6:46 PM Joel Stanley wrote: > > Hello Troy, > > On Wed, 12 Jan 2022 at 08:10, Troy Lee wrote: > > > > Accumulative mode will supply a initial state and append padding bit at > > the end of hash stream. However, the crypto library will padding those > > bit automa

Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-02-08 Thread Joel Stanley
Hello Troy, On Wed, 12 Jan 2022 at 08:10, Troy Lee wrote: > > Accumulative mode will supply a initial state and append padding bit at > the end of hash stream. However, the crypto library will padding those > bit automatically, so ripped it off from iov array. > > The aspeed ast2600 acculumative

Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-01-17 Thread Cédric Le Goater
-static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode) +static void do_hash_operation(AspeedHACEState *s, int algo, bool sg_mode, +  bool acc_mode)   {   struct iovec iov[ASPEED_HACE_MAX_SG];   g_autofree uint8_t *digest_buf; @@ -103,6 +1

Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-01-17 Thread Cédric Le Goater
Hello Troy, On 1/12/22 09:09, Troy Lee wrote: Accumulative mode will supply a initial state and append padding bit at the end of hash stream. However, the crypto library will padding those bit automatically, so ripped it off from iov array. The aspeed ast2600 acculumative mode is described in

[PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-01-12 Thread Troy Lee
Accumulative mode will supply a initial state and append padding bit at the end of hash stream. However, the crypto library will padding those bit automatically, so ripped it off from iov array. The aspeed ast2600 acculumative mode is described in datasheet ast2600v10.pdf section 25.6.4: 1. Allo

Re: [PATCH v2 1/2] hw/misc: Supporting AST2600 HACE accumulative mode

2022-01-12 Thread Troy Lee
[ Adding Klaus ] Sorry I forgot to add Klaus to the CC list. On Wed, Jan 12, 2022 at 4:10 PM Troy Lee wrote: > > Accumulative mode will supply a initial state and append padding bit at > the end of hash stream. However, the crypto library will padding those > bit automatically, so ripped it off