Re: [PATCH v2 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode

2020-12-29 Thread Philippe Mathieu-Daudé
On 12/28/20 8:30 PM, Mark Cave-Ayland wrote: > On 27/12/2020 22:13, BALATON Zoltan wrote: > >> We'll need a flag for implementing some device specific behaviour in >> via-ide but we already have a currently CMD646 specific field that can >> be repurposed for this and leave room for further flags i

Re: [PATCH v2 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode

2020-12-28 Thread BALATON Zoltan via
On Mon, 28 Dec 2020, Mark Cave-Ayland wrote: On 27/12/2020 22:13, BALATON Zoltan wrote: We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for further flags if needed i

Re: [PATCH v2 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode

2020-12-28 Thread Mark Cave-Ayland
On 27/12/2020 22:13, BALATON Zoltan wrote: We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for further flags if needed in the future. This patch changes the "secondar

[PATCH v2 1/2] ide: Make room for flags in PCIIDEState and add one for legacy mode

2020-12-27 Thread BALATON Zoltan via
We'll need a flag for implementing some device specific behaviour in via-ide but we already have a currently CMD646 specific field that can be repurposed for this and leave room for further flags if needed in the future. This patch changes the "secondary" field to "flags" and change CMD646 and its