Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-28 Thread Samuel Thibault
Hello, Doug Evans, le lun. 08 févr. 2021 10:59:01 -0800, a ecrit: > Samuel, how do qemu patches involving libslirp changes usually work? Well, we haven't had many yet actually :) > Should I have held off submitting the qemu patch until the libslirp > prerequisite has been added to qemu's tree,

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-08 Thread Doug Evans
On Mon, Feb 8, 2021 at 3:09 AM Philippe Mathieu-Daudé wrote: > Hi Doug, > > On 2/3/21 10:37 PM, dje--- via wrote: > > ... in preparation for adding ipv6 host forwarding support. > > Please duplicate subject line, else this commit description as it > doesn't make sense. > Hmmm. Is this a bug in

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-08 Thread Philippe Mathieu-Daudé
Hi Doug, On 2/3/21 10:37 PM, dje--- via wrote: > ... in preparation for adding ipv6 host forwarding support. Please duplicate subject line, else this commit description as it doesn't make sense. > --- > net/slirp.c | 200 +--- > slirp | 2

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Doug Evans
On Wed, Feb 3, 2021 at 2:15 PM Samuel Thibault wrote: > Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit: > > ... in preparation for adding ipv6 host forwarding support. > > Reviewed-by: Samuel Thibault > > except > > > diff --git a/slirp b/slirp > > index 8f43a99191..358c0827d4 16

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Samuel Thibault
Doug Evans, le mer. 03 févr. 2021 13:37:28 -0800, a ecrit: > ... in preparation for adding ipv6 host forwarding support. Reviewed-by: Samuel Thibault except > diff --git a/slirp b/slirp > index 8f43a99191..358c0827d4 16 > --- a/slirp > +++ b/slirp > @@ -1 +1 @@ > -Subproject commit

Re: [PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread Doug Evans
On Wed, Feb 3, 2021 at 1:37 PM Doug Evans wrote: > ... in preparation for adding ipv6 host forwarding support. > --- > net/slirp.c | 200 +--- > slirp | 2 +- > 2 files changed, 130 insertions(+), 72 deletions(-) > > diff --git

[PATCH v2 1/2] net/slirp.c: Refactor address parsing

2021-02-03 Thread dje--- via
... in preparation for adding ipv6 host forwarding support. --- net/slirp.c | 200 +--- slirp | 2 +- 2 files changed, 130 insertions(+), 72 deletions(-) diff --git a/net/slirp.c b/net/slirp.c index be914c0be0..a21a313302 100644 ---