Re: [PATCH v2 1/2] s390x: fix memleaks in cpu_finalize

2020-02-20 Thread Peter Maydell
On Thu, 20 Feb 2020 at 16:01, Cornelia Huck wrote: > I may be missing something, but what cleans up the timers if we fail > further down in this function? I don't think the unrealize callback is > invoked by the core in case of error? FWIW I sent a mail to one of these threads a few days ago wher

Re: [PATCH v2 1/2] s390x: fix memleaks in cpu_finalize

2020-02-20 Thread Cornelia Huck
On Mon, 17 Feb 2020 11:21:26 +0800 wrote: > From: Pan Nengyuan > > This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The > leak stack is as follow: > > Direct leak of 48 byte(s) in 1 object(s) allocated from: > #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libas

Re: [PATCH v2 1/2] s390x: fix memleaks in cpu_finalize

2020-02-17 Thread Philippe Mathieu-Daudé
On 2/17/20 4:21 AM, pannengy...@huawei.com wrote: From: Pan Nengyuan This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The leak stack is as follow: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so

[PATCH v2 1/2] s390x: fix memleaks in cpu_finalize

2020-02-16 Thread pannengyuan
From: Pan Nengyuan This patch fix memleaks when we call tests/qtest/cpu-plug-test on s390x. The leak stack is as follow: Direct leak of 48 byte(s) in 1 object(s) allocated from: #0 0x7fb43c7cd970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7fb43be2149d in g_malloc0 (/lib6