Re: [PATCH v2 1/3] block: Make bdrv_refresh_limits() non-recursive

On 04.03.22 15:14, Kevin Wolf wrote: Am 04.03.2022 um 13:44 hat Hanna Reitz geschrieben: On 03.03.22 17:56, Kevin Wolf wrote: Am 16.02.2022 um 11:53 hat Hanna Reitz geschrieben: bdrv_refresh_limits() recurses down to the node's children. That does not seem necessary: When we refresh limits on

Re: [PATCH v2 1/3] block: Make bdrv_refresh_limits() non-recursive

Am 04.03.2022 um 13:44 hat Hanna Reitz geschrieben: > On 03.03.22 17:56, Kevin Wolf wrote: > > Am 16.02.2022 um 11:53 hat Hanna Reitz geschrieben: > > > bdrv_refresh_limits() recurses down to the node's children. That does > > > not seem necessary: When we refresh limits on some node, and then > >

Re: [PATCH v2 1/3] block: Make bdrv_refresh_limits() non-recursive

On 03.03.22 17:56, Kevin Wolf wrote: Am 16.02.2022 um 11:53 hat Hanna Reitz geschrieben: bdrv_refresh_limits() recurses down to the node's children. That does not seem necessary: When we refresh limits on some node, and then recurse down and were to change one of its children's BlockLimits, the

Re: [PATCH v2 1/3] block: Make bdrv_refresh_limits() non-recursive

Am 16.02.2022 um 11:53 hat Hanna Reitz geschrieben: > bdrv_refresh_limits() recurses down to the node's children. That does > not seem necessary: When we refresh limits on some node, and then > recurse down and were to change one of its children's BlockLimits, then > that would mean we noticed the

[PATCH v2 1/3] block: Make bdrv_refresh_limits() non-recursive

bdrv_refresh_limits() recurses down to the node's children. That does not seem necessary: When we refresh limits on some node, and then recurse down and were to change one of its children's BlockLimits, then that would mean we noticed the changed limits by pure chance. The fact that we refresh th