Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Jason Wang
在 2021/7/14 下午5:14, Bin Meng 写道: On Wed, Jul 14, 2021 at 5:01 PM Peter Maydell wrote: On Wed, 14 Jul 2021 at 04:42, Bin Meng wrote: On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: 在 2021/7/13 下午5:11, Bin Meng 写道: Can we get some agreement among maintainers? It's not about the agree

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Jason Wang
在 2021/7/14 下午5:05, Bin Meng 写道: On Wed, Jul 14, 2021 at 4:40 PM Jason Wang wrote: 在 2021/7/14 下午2:04, Bin Meng 写道: On Wed, Jul 14, 2021 at 12:53 PM Jason Wang wrote: 在 2021/7/14 上午11:42, Bin Meng 写道: On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: 在 2021/7/13 下午5:11, Bin Meng 写道:

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Bin Meng
On Wed, Jul 14, 2021 at 5:01 PM Peter Maydell wrote: > > On Wed, 14 Jul 2021 at 04:42, Bin Meng wrote: > > > > On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: > > > > > > > > > 在 2021/7/13 下午5:11, Bin Meng 写道: > > > > Can we get some agreement among maintainers? > > > > > > > > > It's not abo

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Bin Meng
On Wed, Jul 14, 2021 at 4:40 PM Jason Wang wrote: > > > 在 2021/7/14 下午2:04, Bin Meng 写道: > > On Wed, Jul 14, 2021 at 12:53 PM Jason Wang wrote: > >> > >> 在 2021/7/14 上午11:42, Bin Meng 写道: > >>> On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: > 在 2021/7/13 下午5:11, Bin Meng 写道: > > On

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Peter Maydell
On Wed, 14 Jul 2021 at 04:42, Bin Meng wrote: > > On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: > > > > > > 在 2021/7/13 下午5:11, Bin Meng 写道: > > > Can we get some agreement among maintainers? > > > > > > It's not about the agreement but about to have a stable ABI. I don't > > know the case f

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-14 Thread Jason Wang
在 2021/7/14 下午2:04, Bin Meng 写道: On Wed, Jul 14, 2021 at 12:53 PM Jason Wang wrote: 在 2021/7/14 上午11:42, Bin Meng 写道: On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: 在 2021/7/13 下午5:11, Bin Meng 写道: On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: 在 2021/7/13 下午4:36, Bin Meng 写道:

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Bin Meng
On Wed, Jul 14, 2021 at 12:53 PM Jason Wang wrote: > > > 在 2021/7/14 上午11:42, Bin Meng 写道: > > On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: > >> > >> 在 2021/7/13 下午5:11, Bin Meng 写道: > >>> On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: > 在 2021/7/13 下午4:36, Bin Meng 写道: > > On

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Jason Wang
在 2021/7/14 上午11:42, Bin Meng 写道: On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: 在 2021/7/13 下午5:11, Bin Meng 写道: On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: 在 2021/7/13 下午4:36, Bin Meng 写道: On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: 在 2021/7/13 上午7:06, Bin Meng 写道: O

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Bin Meng
On Wed, Jul 14, 2021 at 11:10 AM Jason Wang wrote: > > > 在 2021/7/13 下午5:11, Bin Meng 写道: > > On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: > >> > >> 在 2021/7/13 下午4:36, Bin Meng 写道: > >>> On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: > 在 2021/7/13 上午7:06, Bin Meng 写道: > > On Mo

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Jason Wang
在 2021/7/13 下午5:11, Bin Meng 写道: On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: 在 2021/7/13 下午4:36, Bin Meng 写道: On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: 在 2021/7/13 上午7:06, Bin Meng 写道: On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: On Mon, Jul 5, 2021 at 12:21 PM Jason Wa

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Bin Meng
On Tue, Jul 13, 2021 at 5:02 PM Jason Wang wrote: > > > 在 2021/7/13 下午4:36, Bin Meng 写道: > > On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: > >> > >> 在 2021/7/13 上午7:06, Bin Meng 写道: > >>> On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: > On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote:

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Jason Wang
在 2021/7/13 下午4:36, Bin Meng 写道: On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: 在 2021/7/13 上午7:06, Bin Meng 写道: On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote: 在 2021/7/2 下午5:24, Bin Meng 写道: From: Christina Wang The initial value

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Bin Meng
On Tue, Jul 13, 2021 at 3:03 PM Jason Wang wrote: > > > 在 2021/7/13 上午7:06, Bin Meng 写道: > > On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: > >> On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote: > >>> > >>> 在 2021/7/2 下午5:24, Bin Meng 写道: > From: Christina Wang > > The initial va

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-13 Thread Jason Wang
在 2021/7/13 上午7:06, Bin Meng 写道: On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote: 在 2021/7/2 下午5:24, Bin Meng 写道: From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. Whi

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-12 Thread Bin Meng
On Mon, Jul 5, 2021 at 1:57 PM Bin Meng wrote: > > On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote: > > > > > > 在 2021/7/2 下午5:24, Bin Meng 写道: > > > From: Christina Wang > > > > > > The initial value of VLAN Ether Type (VET) register is 0x8100, as per > > > the manual and real hardware. > > >

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-04 Thread Bin Meng
On Mon, Jul 5, 2021 at 12:21 PM Jason Wang wrote: > > > 在 2021/7/2 下午5:24, Bin Meng 写道: > > From: Christina Wang > > > > The initial value of VLAN Ether Type (VET) register is 0x8100, as per > > the manual and real hardware. > > > > While Linux e1000 driver always writes VET register to 0x8100, i

Re: [PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-04 Thread Jason Wang
在 2021/7/2 下午5:24, Bin Meng 写道: From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000 driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value o

[PATCH v2 1/3] hw/net: e1000: Correct the initial value of VET register

2021-07-02 Thread Bin Meng
From: Christina Wang The initial value of VLAN Ether Type (VET) register is 0x8100, as per the manual and real hardware. While Linux e1000 driver always writes VET register to 0x8100, it is not always the case for everyone. Drivers relying on the reset value of VET won't be able to transmit and