Re: [PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-05-11 Thread Markus Armbruster
First of all, my sincere apologies for the delayed review. The patch series needs a rebase. But let me review it first. Dinah Baum writes: > Moved architecture agnostic data types to their own > file to avoid "attempt to use poisoned TARGET_*" > error that results when including qapi header >

[PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-04-03 Thread Dinah Baum
Moved architecture agnostic data types to their own file to avoid "attempt to use poisoned TARGET_*" error that results when including qapi header with commands that aren't defined for all architectures. Required to implement enabling `query-cpu-model-expansion` on all architectures

Re: [PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-03-14 Thread Philippe Mathieu-Daudé
On 14/3/23 11:00, Dinah Baum wrote: Moved architecture agnostic data types to their own file to avoid "attempt to use poisoned TARGET_*" error that results when including qapi header with commands that aren't defined for all architectures. Required to implement enabling

[PATCH v2 1/3] qapi/machine-target: refactor machine-target

2023-03-14 Thread Dinah Baum
Moved architecture agnostic data types to their own file to avoid "attempt to use poisoned TARGET_*" error that results when including qapi header with commands that aren't defined for all architectures. Required to implement enabling `query-cpu-model-expansion` on all architectures