Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-17 Thread BALATON Zoltan
On Tue, 17 Oct 2023, Mark Cave-Ayland wrote: On 16/10/2023 23:16, BALATON Zoltan wrote: On Sun, 15 Oct 2023, Mark Cave-Ayland wrote: On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: Using the portio_list*() APIs really is the right way to implement this

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-17 Thread Mark Cave-Ayland
On 16/10/2023 23:16, BALATON Zoltan wrote: On Sun, 15 Oct 2023, Mark Cave-Ayland wrote: On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-16 Thread BALATON Zoltan
On Sun, 15 Oct 2023, Mark Cave-Ayland wrote: On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-15 Thread BALATON Zoltan
On Sun, 15 Oct 2023, Mark Cave-Ayland wrote: On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-15 Thread Mark Cave-Ayland
On 14/10/2023 20:43, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-15 Thread Mark Cave-Ayland
On 14/10/2023 17:13, BALATON Zoltan wrote: On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-15 Thread Bernhard Beschow
Am 14. Oktober 2023 16:13:19 UTC schrieb BALATON Zoltan : >On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: >> On 09/10/2023 20:54, BALATON Zoltan wrote: >> >>> The initial value for BARs were set in reset method for emulating >>> legacy mode at start but this does not work because PCI code resets

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-14 Thread BALATON Zoltan
On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-14 Thread BALATON Zoltan
On Sat, 14 Oct 2023, Mark Cave-Ayland wrote: On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default

Re: [PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-14 Thread Mark Cave-Ayland
On 09/10/2023 20:54, BALATON Zoltan wrote: The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default to avoid confusion. Instead move setting the

[PATCH v2 1/3] via-ide: Fix legacy mode emulation

2023-10-09 Thread BALATON Zoltan
The initial value for BARs were set in reset method for emulating legacy mode at start but this does not work because PCI code resets BARs after calling device reset method. Remove this ineffective default to avoid confusion. Instead move setting the BARs to a callback on writing the PCI config