RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-03-11 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com; > dgilb...@redhat.com; Juan Jose Quintela Carreira > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > [...] > > We should instead think about

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-28 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com; >> dgilb...@redhat.com; Juan Jose Quintela Carreira >&

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-28 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com; > dgilb...@redhat.com; Juan Jose Quintela Carreira > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback [...] > >> Thanks for that. I had a g

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-13 Thread David Hildenbrand
othum Thodi ; >>> Igor Mammedov >>> Cc: peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; >>> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >>> xuwei (O) ; Linuxarm ; >>> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-13 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com; >> dgilb...@redhat.com; Juan Jose Quintela Carreira >> Subject: Re: [PATC

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-13 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com; > dgilb...@redhat.com; Juan Jose Quintela Carreira > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback [...] > > Hmm..it breaks x86 + seabios boot. Th

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-12 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com >> Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize()

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-12 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > > On 10.02.20 10:50, Shameerali Kolothum Thodi wrote: > > > > > >> -Orig

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-10 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com >> Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback >> &g

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-10 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > > >> Can you look the original value up somehow and us the resize callback > >> only as

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-10 Thread David Hildenbrand
>> Can you look the original value up somehow and us the resize callback >> only as a notification that something changed? (that value would have to >> be stored somewhere and migrated I assume - maybe that's already being >> done) > > Ok. I will take a look at that. But can we instead pass the

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-07 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > > On 06.02.20 12:28, Shameerali Kolothum Thodi wrote: > > > > > >> -Orig

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com >> Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > >

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback [...] > > root@ubuntu:/# cat /dev/pmem > > pmem0 pmem1 > > > > From the logs, it

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread David Hildenbrand
ro.org; xiaoguangrong.e...@gmail.com; >> m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; >> xuwei (O) ; Linuxarm ; >> eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com >> Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callb

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-06 Thread Shameerali Kolothum Thodi
qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > > >> Oh, and one more reason why the proposal in this patch is inconsistent: > &g

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-05 Thread David Hildenbrand
>> Oh, and one more reason why the proposal in this patch is inconsistent: >> >> When migrating resizable memory regions (RAM_SAVE_FLAG_MEM_SIZE) we >> store the block->used_length (ram_save_setup()) and use that value to >> resize the region on the target (ram_load_precopy() ->

RE: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-05 Thread Shameerali Kolothum Thodi
peter.mayd...@linaro.org; xiaoguangrong.e...@gmail.com; > m...@redhat.com; shannon.zha...@gmail.com; qemu-devel@nongnu.org; > xuwei (O) ; Linuxarm ; > eric.au...@redhat.com; qemu-...@nongnu.org; ler...@redhat.com > Subject: Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback > >

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-04 Thread David Hildenbrand
On 04.02.20 17:44, David Hildenbrand wrote: > On 04.02.20 16:23, Igor Mammedov wrote: >> On Fri, 17 Jan 2020 17:45:16 + >> Shameer Kolothum wrote: >> >>> If ACPI blob length modifications happens after the initial >>> virt_acpi_build() call, and the changed blob length is within >>> the PAGE

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-04 Thread David Hildenbrand
On 04.02.20 16:23, Igor Mammedov wrote: > On Fri, 17 Jan 2020 17:45:16 + > Shameer Kolothum wrote: > >> If ACPI blob length modifications happens after the initial >> virt_acpi_build() call, and the changed blob length is within >> the PAGE size boundary, then the revised size is not seen by

Re: [PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-02-04 Thread Igor Mammedov
On Fri, 17 Jan 2020 17:45:16 + Shameer Kolothum wrote: > If ACPI blob length modifications happens after the initial > virt_acpi_build() call, and the changed blob length is within > the PAGE size boundary, then the revised size is not seen by > the firmware on Guest reboot. The is because

[PATCH v2 1/7] exec: Fix for qemu_ram_resize() callback

2020-01-17 Thread Shameer Kolothum
If ACPI blob length modifications happens after the initial virt_acpi_build() call, and the changed blob length is within the PAGE size boundary, then the revised size is not seen by the firmware on Guest reboot. The is because in the virt_acpi_build_update() -> acpi_ram_update() ->