Re: [PATCH v2 1/8] linux-user: test, don't assert addr != test in pgb_reserved_va

2020-09-15 Thread Richard Henderson
On 9/15/20 6:43 AM, Alex Bennée wrote: > On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel > may still fail to give us the address we asked for despite having > already probed the map for a valid hole. Asserting isn't particularly > useful to the user so let us move the check

Re: [PATCH v2 1/8] linux-user: test, don't assert addr != test in pgb_reserved_va

2020-09-15 Thread Laurent Vivier
Le 15/09/2020 à 15:43, Alex Bennée a écrit : > On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel > may still fail to give us the address we asked for despite having > already probed the map for a valid hole. Asserting isn't particularly > useful to the user so let us move the

[PATCH v2 1/8] linux-user: test, don't assert addr != test in pgb_reserved_va

2020-09-15 Thread Alex Bennée
On older kernels which don't implement MAP_FIXED_NOREPLACE the kernel may still fail to give us the address we asked for despite having already probed the map for a valid hole. Asserting isn't particularly useful to the user so let us move the check up and expand the error_report a little to give