Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Minwoo Im
On 21-01-18 20:23:30, Klaus Jensen wrote: > On Jan 18 14:22, Klaus Jensen wrote: > > On Jan 18 22:12, Minwoo Im wrote: > > > On 21-01-18 14:10:50, Klaus Jensen wrote: > > > > On Jan 18 22:09, Minwoo Im wrote: > > > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to > > > > > >

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
On Jan 18 14:22, Klaus Jensen wrote: > On Jan 18 22:12, Minwoo Im wrote: > > On 21-01-18 14:10:50, Klaus Jensen wrote: > > > On Jan 18 22:09, Minwoo Im wrote: > > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move > > > > > > onto > > > > > > the CMB v1.4 from v1.3

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
On Jan 18 22:12, Minwoo Im wrote: > On 21-01-18 14:10:50, Klaus Jensen wrote: > > On Jan 18 22:09, Minwoo Im wrote: > > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move > > > > > onto > > > > > the CMB v1.4 from v1.3 without supporting the v1.3 usage on this > > > > >

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
On Jan 18 22:09, Minwoo Im wrote: > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move onto > > > the CMB v1.4 from v1.3 without supporting the v1.3 usage on this device > > > model? > > > > Next patch moves to v1.4. I wanted to split it because the "bump" patch > > also adds

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Minwoo Im
On 21-01-18 14:10:50, Klaus Jensen wrote: > On Jan 18 22:09, Minwoo Im wrote: > > > > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move onto > > > > the CMB v1.4 from v1.3 without supporting the v1.3 usage on this device > > > > model? > > > > > > Next patch moves to v1.4. I

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Minwoo Im
> > Yes, CMB in v1.4 is not backward-compatible, but is it okay to move onto > > the CMB v1.4 from v1.3 without supporting the v1.3 usage on this device > > model? > > Next patch moves to v1.4. I wanted to split it because the "bump" patch > also adds a couple of other v1.4 requires fields. But I

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
On Jan 18 21:58, Minwoo Im wrote: > Hello, > > On 21-01-18 10:47:03, Klaus Jensen wrote: > > From: Padmakar Kalghatgi > > > > Implement v1.4 logic for configuring the Controller Memory Buffer. This > > is not backward compatible with v1.3, so drivers that only support v1.3 > > will not be able

Re: [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Minwoo Im
Hello, On 21-01-18 10:47:03, Klaus Jensen wrote: > From: Padmakar Kalghatgi > > Implement v1.4 logic for configuring the Controller Memory Buffer. This > is not backward compatible with v1.3, so drivers that only support v1.3 > will not be able to use the CMB anymore. > > Signed-off-by:

[PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4

2021-01-18 Thread Klaus Jensen
From: Padmakar Kalghatgi Implement v1.4 logic for configuring the Controller Memory Buffer. This is not backward compatible with v1.3, so drivers that only support v1.3 will not be able to use the CMB anymore. Signed-off-by: Padmakar Kalghatgi Signed-off-by: Klaus Jensen --- hw/block/nvme.h