Re: [PATCH v2 10/42] i386: Rewrite vector shift helper

2022-04-26 Thread Paolo Bonzini
On 4/25/22 23:33, Richard Henderson wrote: I do not think it worthwhile to unroll these loops by hand. Totally agree, as it would also remove most of the uses of XMM_ONLY/YMM_ONLY. I also saw GCC -Warray-bounds complain about if (SHIFT >= 1) { d->elem[8] = s->elem[8]

Re: [PATCH v2 10/42] i386: Rewrite vector shift helper

2022-04-25 Thread Richard Henderson
On 4/24/22 15:01, Paul Brook wrote: Rewrite the vector shift helpers in preperation for AVX support (3 operand form and 256 bit vectors). For now keep the existing two operand interface. No functional changes to existing helpers. Signed-off-by: Paul Brook --- target/i386/ops_sse.h | 250 +++

[PATCH v2 10/42] i386: Rewrite vector shift helper

2022-04-24 Thread Paul Brook
Rewrite the vector shift helpers in preperation for AVX support (3 operand form and 256 bit vectors). For now keep the existing two operand interface. No functional changes to existing helpers. Signed-off-by: Paul Brook --- target/i386/ops_sse.h | 250 ++