Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-17 Thread Peter Maydell
On Fri, 14 Jul 2023 at 20:13, Stefan Berger wrote: > Unfortunately the CRB device is being used by x86 on some distros > and the expectation is that this existing device can also downgrade > to a previous version of QEMU I would say. I have read people migrating > from RHEL 9.x even to RHEL 8.x an

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-17 Thread Igor Mammedov
On Fri, 14 Jul 2023 11:49:03 -0700 Joelle van Dyne wrote: > On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger wrote: > > > > > > > > On 7/14/23 14:22, Stefan Berger wrote: > > > On 7/14/23 13:04, Joelle van Dyne wrote: > > >> On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger > > >> wrote: > > >

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 15:44, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 12:12 PM Stefan Berger wrote: On 7/14/23 14:49, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger wrote: On 7/14/23 14:22, Stefan Berger wrote: On 7/14/23 13:04, Joelle van Dyne wrote: On Fri, Jul

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 12:12 PM Stefan Berger wrote: > > > > On 7/14/23 14:49, Joelle van Dyne wrote: > > On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger > > wrote: > >> > >> > >> > >> On 7/14/23 14:22, Stefan Berger wrote: > >>> On 7/14/23 13:04, Joelle van Dyne wrote: > On Fri, Jul 14, 20

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 14:49, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger wrote: On 7/14/23 14:22, Stefan Berger wrote: On 7/14/23 13:04, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger wrote: On 7/14/23 10:05, Stefan Berger wrote: On 7/14/23 0

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 11:41 AM Stefan Berger wrote: > > > > On 7/14/23 14:22, Stefan Berger wrote: > > On 7/14/23 13:04, Joelle van Dyne wrote: > >> On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger > >> wrote: > >>> > >>> > >>> > >>> On 7/14/23 10:05, Stefan Berger wrote: > > > On

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 14:22, Stefan Berger wrote: On 7/14/23 13:04, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger wrote: On 7/14/23 10:05, Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: When we moved to a single mapping and modified TPM CRB's VMState, it br

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 13:04, Joelle van Dyne wrote: On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger wrote: On 7/14/23 10:05, Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: When we moved to a single mapping and modified TPM CRB's VMState, it broke restoring of VMs that were saved on an

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Joelle van Dyne
On Fri, Jul 14, 2023 at 7:51 AM Stefan Berger wrote: > > > > On 7/14/23 10:05, Stefan Berger wrote: > > > > > > On 7/14/23 03:09, Joelle van Dyne wrote: > >> When we moved to a single mapping and modified TPM CRB's VMState, it > >> broke restoring of VMs that were saved on an older version. This >

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 10:05, Stefan Berger wrote: On 7/14/23 03:09, Joelle van Dyne wrote: When we moved to a single mapping and modified TPM CRB's VMState, it broke restoring of VMs that were saved on an older version. This change allows those VMs to gracefully migrate to the new memory mapping. Th

Re: [PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Stefan Berger
On 7/14/23 03:09, Joelle van Dyne wrote: When we moved to a single mapping and modified TPM CRB's VMState, it broke restoring of VMs that were saved on an older version. This change allows those VMs to gracefully migrate to the new memory mapping. Thanks. This has to be in 4/11 though.

[PATCH v2 11/11] tpm_crb: support restoring older vmstate

2023-07-14 Thread Joelle van Dyne
When we moved to a single mapping and modified TPM CRB's VMState, it broke restoring of VMs that were saved on an older version. This change allows those VMs to gracefully migrate to the new memory mapping. Signed-off-by: Joelle van Dyne --- hw/tpm/tpm_crb.h| 1 + hw/tpm/tpm_crb.c