Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-18 Thread Greg Kurz
On Fri, 18 Sep 2020 19:01:34 +0300 Vladimir Sementsov-Ogievskiy wrote: > 18.09.2020 18:51, Alberto Garcia wrote: > > On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: > >>> qcow2_do_open correctly sets errp on each failure path. So, we can > >>> simplify code in qcow2_co_invalidate_cache() an

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-18 Thread Vladimir Sementsov-Ogievskiy
18.09.2020 18:51, Alberto Garcia wrote: On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. We should use ERRP_GUARD() (accordingly to comment in

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-18 Thread Alberto Garcia
On Fri 18 Sep 2020 05:30:06 PM CEST, Greg Kurz wrote: >> qcow2_do_open correctly sets errp on each failure path. So, we can >> simplify code in qcow2_co_invalidate_cache() and drop explicit error >> propagation. We should use ERRP_GUARD() (accordingly to comment in >> include/qapi/error.h) together

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-18 Thread Greg Kurz
On Thu, 17 Sep 2020 22:55:18 +0300 Vladimir Sementsov-Ogievskiy wrote: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. We should use ERRP_GUARD() (accordingly to comment in > include/qapi/er

Re: [PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-18 Thread Alberto Garcia
On Thu 17 Sep 2020 09:55:18 PM CEST, Vladimir Sementsov-Ogievskiy wrote: > qcow2_do_open correctly sets errp on each failure path. So, we can > simplify code in qcow2_co_invalidate_cache() and drop explicit error > propagation. We should use ERRP_GUARD() (accordingly to comment in > include/qapi/er

[PATCH v2 12/13] block/qcow2: simplify qcow2_co_invalidate_cache()

2020-09-17 Thread Vladimir Sementsov-Ogievskiy
qcow2_do_open correctly sets errp on each failure path. So, we can simplify code in qcow2_co_invalidate_cache() and drop explicit error propagation. We should use ERRP_GUARD() (accordingly to comment in include/qapi/error.h) together with error_append() call which we add to avoid problems with erro