Re: [PATCH v2 13/13] block/qed: bdrv_qed_do_open: deal with errp

2020-09-18 Thread Greg Kurz
On Thu, 17 Sep 2020 22:55:19 +0300 Vladimir Sementsov-Ogievskiy wrote: > Set errp always on failure. Generic bdrv_open_driver supports driver > functions which can return negative value and forget to set errp. > That's a strange thing.. Let's improve bdrv_qed_do_open to not behave > this way.

[PATCH v2 13/13] block/qed: bdrv_qed_do_open: deal with errp

2020-09-17 Thread Vladimir Sementsov-Ogievskiy
Set errp always on failure. Generic bdrv_open_driver supports driver functions which can return negative value and forget to set errp. That's a strange thing.. Let's improve bdrv_qed_do_open to not behave this way. This allows to simplify code in bdrv_qed_co_invalidate_cache(). Signed-off-by: