Re: [PATCH v2 13/13] target/riscv: Simplify probing in vext_ldff

2024-07-15 Thread Richard Henderson
On 7/15/24 17:06, Max Chou wrote: +/* Probe nonfault on subsequent elements. */ +flags = probe_access_flags(env, addr, offset, MMU_DATA_LOAD, + mmu_index, true, &host, 0); +if (flags) { According to the sec

Re: [PATCH v2 13/13] target/riscv: Simplify probing in vext_ldff

2024-07-15 Thread Max Chou
On 2024/7/10 11:28 AM, Richard Henderson wrote: The current pairing of tlb_vaddr_to_host with extra is either inefficient (user-only, with page_check_range) or incorrect (system, with probe_pages). For proper non-fault behaviour, use probe_access_flags with its nonfault parameter set to true. S

Re: [PATCH v2 13/13] target/riscv: Simplify probing in vext_ldff

2024-07-09 Thread Alistair Francis
On Wed, Jul 10, 2024 at 1:30 PM Richard Henderson wrote: > > The current pairing of tlb_vaddr_to_host with extra is either > inefficient (user-only, with page_check_range) or incorrect > (system, with probe_pages). > > For proper non-fault behaviour, use probe_access_flags with > its nonfault para

[PATCH v2 13/13] target/riscv: Simplify probing in vext_ldff

2024-07-09 Thread Richard Henderson
The current pairing of tlb_vaddr_to_host with extra is either inefficient (user-only, with page_check_range) or incorrect (system, with probe_pages). For proper non-fault behaviour, use probe_access_flags with its nonfault parameter set to true. Signed-off-by: Richard Henderson --- target/riscv