Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:36PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow Reviewed-by: Cleber Rosa signature.asc Description: PGP signature

Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations

2020-09-23 Thread Eduardo Habkost
On Wed, Sep 23, 2020 at 01:57:25PM -0400, John Snow wrote: > On 9/22/20 6:44 PM, Eduardo Habkost wrote: > > Does this need to require a Sequence? It looks like it could be > > Iterable. > > > > I don't think this should block the patch, though, so: > > > > Reviewed-by: Eduardo Habkost > > gen_i

Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations

2020-09-23 Thread John Snow
On 9/22/20 6:44 PM, Eduardo Habkost wrote: Does this need to require a Sequence? It looks like it could be Iterable. I don't think this should block the patch, though, so: Reviewed-by: Eduardo Habkost gen_if can take an Iterator, gen_endif needs a Sequence because it uses reversed(). I ha

Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations

2020-09-22 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:36PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > --- > scripts/qapi/common.py | 27 --- > 1 file changed, 16 insertions(+), 11 deletions(-) > > d

[PATCH v2 13/38] qapi/common.py: add type hint annotations

2020-09-22 Thread John Snow
Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow --- scripts/qapi/common.py | 27 --- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index 682e74fe65.