Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:38PM -0400, John Snow wrote: > Including it in common.py creates a circular import dependency; schema > relies on common, but common.build_params requires a type annotation > from schema. To type this properly, it needs to be moved outside the > cycle. > > Signed-off-

Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:38PM -0400, John Snow wrote: > Including it in common.py creates a circular import dependency; schema > relies on common, but common.build_params requires a type annotation > from schema. To type this properly, it needs to be moved outside the > cycle. > > Signed-off-

[PATCH v2 15/38] qapi/common.py: move build_params into gen.py

2020-09-22 Thread John Snow
Including it in common.py creates a circular import dependency; schema relies on common, but common.build_params requires a type annotation from schema. To type this properly, it needs to be moved outside the cycle. Signed-off-by: John Snow --- scripts/qapi/commands.py | 8 ++-- scripts/qap