Re: [PATCH v2 16/53] migration/rdma: Fix or document problematic uses of errno

2023-10-06 Thread Zhijian Li (Fujitsu)
On 28/09/2023 21:19, Markus Armbruster wrote: > We use errno after calling Libibverbs functions that are not > documented to set errno (manual page does not mention errno), or where > the documentation is unclear ("returns [...] the value of errno on > failure"). While this could be read as "set

Re: [PATCH v2 16/53] migration/rdma: Fix or document problematic uses of errno

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > We use errno after calling Libibverbs functions that are not > documented to set errno (manual page does not mention errno), or where > the documentation is unclear ("returns [...] the value of errno on > failure"). While this could be read as "sets errno and returns it

Re: [PATCH v2 16/53] migration/rdma: Fix or document problematic uses of errno

2023-10-04 Thread Markus Armbruster
Fabiano Rosas writes: > Markus Armbruster writes: > >> We use errno after calling Libibverbs functions that are not >> documented to set errno (manual page does not mention errno), or where >> the documentation is unclear ("returns [...] the value of errno on >> failure"). While this could be r

Re: [PATCH v2 16/53] migration/rdma: Fix or document problematic uses of errno

2023-09-29 Thread Fabiano Rosas
Markus Armbruster writes: > We use errno after calling Libibverbs functions that are not > documented to set errno (manual page does not mention errno), or where > the documentation is unclear ("returns [...] the value of errno on > failure"). While this could be read as "sets errno and returns

[PATCH v2 16/53] migration/rdma: Fix or document problematic uses of errno

2023-09-28 Thread Markus Armbruster
We use errno after calling Libibverbs functions that are not documented to set errno (manual page does not mention errno), or where the documentation is unclear ("returns [...] the value of errno on failure"). While this could be read as "sets errno and returns it", a glance at the source code[*]