Re: [PATCH v2 18/22] qga: don't disable fsfreeze commands if vss_init fails

2024-07-12 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 01:21:29PM +0300, Manos Pitsidianakis wrote: > On Thu, 13 Jun 2024 18:44, "Daniel P. Berrangé" wrote: > > The fsfreeze commands are already written to report an error if > > vss_init() fails. Reporting a more specific error message is more > > helpful than a generic "comman

Re: [PATCH v2 18/22] qga: don't disable fsfreeze commands if vss_init fails

2024-07-03 Thread Manos Pitsidianakis
On Thu, 13 Jun 2024 18:44, "Daniel P. Berrangé" wrote: The fsfreeze commands are already written to report an error if vss_init() fails. Reporting a more specific error message is more helpful than a generic "command is disabled" message, which cannot beteween an admin config decision and lack o

[PATCH v2 18/22] qga: don't disable fsfreeze commands if vss_init fails

2024-06-13 Thread Daniel P . Berrangé
The fsfreeze commands are already written to report an error if vss_init() fails. Reporting a more specific error message is more helpful than a generic "command is disabled" message, which cannot beteween an admin config decision and lack of platform support. Signed-off-by: Daniel P. Berrangé --