On 9/28/20 7:49 AM, Markus Armbruster wrote:
John Snow writes:
On 9/25/20 8:19 AM, Markus Armbruster wrote:
What about:
Generate a QAPI struct variable holding the event parameters,
initialized with the function's arguments.
Line length and style-guide limitations; docstrings
John Snow writes:
> On 9/25/20 8:19 AM, Markus Armbruster wrote:
>> What about:
>> Generate a QAPI struct variable holding the event parameters,
>> initialized with the function's arguments.
>
> Line length and style-guide limitations; docstrings need a one-liner
> summary.
They do!
On 9/25/20 8:19 AM, Markus Armbruster wrote:
What about:
Generate a QAPI struct variable holding the event parameters,
initialized with the function's arguments.
Line length and style-guide limitations; docstrings need a one-liner
summary.
(Consistency is the hobgoblin, blah blah
Eduardo Habkost writes:
> On Tue, Sep 22, 2020 at 05:00:41PM -0400, John Snow wrote:
>> Signed-off-by: John Snow
>> ---
>> scripts/qapi/events.py | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
>> index
On Tue, Sep 22, 2020 at 05:00:41PM -0400, John Snow wrote:
> Signed-off-by: John Snow
Reviewed-by: Cleber Rosa
signature.asc
Description: PGP signature
On 9/23/20 10:48 AM, Eduardo Habkost wrote:
On Tue, Sep 22, 2020 at 05:00:41PM -0400, John Snow wrote:
Signed-off-by: John Snow
---
scripts/qapi/events.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
index
On Tue, Sep 22, 2020 at 05:00:41PM -0400, John Snow wrote:
> Signed-off-by: John Snow
> ---
> scripts/qapi/events.py | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
> index 00a9513c16..e859fd7a52 100644
> ---
Signed-off-by: John Snow
---
scripts/qapi/events.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/events.py b/scripts/qapi/events.py
index 00a9513c16..e859fd7a52 100644
--- a/scripts/qapi/events.py
+++ b/scripts/qapi/events.py
@@ -52,8 +52,10 @@ def