Peter Xu writes:
> On Wed, Aug 02, 2023 at 05:04:45PM -0300, Fabiano Rosas wrote:
>> Peter Xu writes:
>>
>> >> +if (await_return_path_close_on_source(s)) {
>> >> +trace_migration_return_path_pause_err();
>> >> +return MIG_THR_ERR_FATAL;
>> >> +}
>> >
>>
On Wed, Aug 02, 2023 at 05:04:45PM -0300, Fabiano Rosas wrote:
> Peter Xu writes:
>
> >> +if (await_return_path_close_on_source(s)) {
> >> +trace_migration_return_path_pause_err();
> >> +return MIG_THR_ERR_FATAL;
> >> +}
> >
> > I see that here on return
Peter Xu writes:
>> +if (await_return_path_close_on_source(s)) {
>> +trace_migration_return_path_pause_err();
>> +return MIG_THR_ERR_FATAL;
>> +}
>
> I see that here on return path failures we'll bail out, and actually it's
> against the instinction (that
On Wed, Aug 02, 2023 at 11:36:44AM -0300, Fabiano Rosas wrote:
> Replace the return path retry logic with finishing and restarting the
> thread. This fixes a race when resuming the migration that leads to a
> segfault.
>
> Currently when doing postcopy we consider that an IO error on the
> return
Replace the return path retry logic with finishing and restarting the
thread. This fixes a race when resuming the migration that leads to a
segfault.
Currently when doing postcopy we consider that an IO error on the
return path file could be due to a network intermittency. We then keep
the thread
