Re: [PATCH v2 2/3] hw/i386/acpi-build: Resolve redundant attribute

2022-10-31 Thread Bernhard Beschow
Am 31. Oktober 2022 17:41:59 UTC schrieb "Michael S. Tsirkin" : >On Mon, Oct 31, 2022 at 01:45:29PM +0100, Igor Mammedov wrote: >> On Fri, 28 Oct 2022 12:34:18 +0200 >> Bernhard Beschow wrote: >> >> > The is_piix4 attribute is set once in one location and read once in >> > another. Doing both in

Re: [PATCH v2 2/3] hw/i386/acpi-build: Resolve redundant attribute

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 01:45:29PM +0100, Igor Mammedov wrote: > On Fri, 28 Oct 2022 12:34:18 +0200 > Bernhard Beschow wrote: > > > The is_piix4 attribute is set once in one location and read once in > > another. Doing both in one location allows for removing the attribute > > altogether. > > we

Re: [PATCH v2 2/3] hw/i386/acpi-build: Resolve redundant attribute

2022-10-31 Thread Igor Mammedov
On Fri, 28 Oct 2022 12:34:18 +0200 Bernhard Beschow wrote: > The is_piix4 attribute is set once in one location and read once in > another. Doing both in one location allows for removing the attribute > altogether. we also test for piix4 in acpi_get_pm_info(), Perhaps we should move is_piix4 to

[PATCH v2 2/3] hw/i386/acpi-build: Resolve redundant attribute

2022-10-28 Thread Bernhard Beschow
The is_piix4 attribute is set once in one location and read once in another. Doing both in one location allows for removing the attribute altogether. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20221026133110.91828-3-shen...@gmail.com> --- hw/i386/acpi-build