Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Eric Blake
On 11/18/19 1:10 PM, Philippe Mathieu-Daudé wrote: -    trace_gt64120_write("INTRCAUSE", size << 1, val); +    trace_gt64120_write("INTRCAUSE", size << 3, val); Again, this isn't mentioned in the commit message.  Why are you changing parameter values? +++ b/hw/mips/trace-events

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-18 Thread Philippe Mathieu-Daudé
On 11/14/19 10:24 PM, Philippe Mathieu-Daudé wrote: On 11/8/19 4:58 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-14 Thread Philippe Mathieu-Daudé
On 11/8/19 4:58 PM, Eric Blake wrote: On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink:

Re: [PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-08 Thread Eric Blake
On 11/8/19 8:40 AM, Philippe Mathieu-Daudé wrote: Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe

[PATCH v2 2/3] hw/mips/gt64xxx: Remove dynamic field width from trace events

2019-11-08 Thread Philippe Mathieu-Daudé
Since not all trace backends support dynamic field width in format (dtrace via stap does not), replace by a static field width instead. Reported-by: Eric Blake Buglink: https://bugs.launchpad.net/qemu/+bug/1844817 Signed-off-by: Philippe Mathieu-Daudé --- v2: Do not update qemu_log_mask() ---