Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Daniel P . Berrangé
On Mon, Sep 07, 2020 at 11:14:41AM +0200, Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of slave disks is also listed and > /dev path is used as a handle so it can be matched with "name" filed of > other returned disk

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Marc-André Lureau
Hi On Tue, Oct 6, 2020 at 12:31 PM Tomáš Golembiovský wrote: > On Tue, Sep 29, 2020 at 07:22:00PM +0400, Marc-André Lureau wrote: > > > > +if (getline(&line, &n, fp) == -1) { > > > +g_debug(" failed to read disk size"); > > > > > > > line: getline(3) "This buffer should be f

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-10-06 Thread Tomáš Golembiovský
On Tue, Sep 29, 2020 at 07:22:00PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Sep 7, 2020 at 1:17 PM Tomáš Golembiovský > wrote: > > > The command lists all disks (real and virtual) as well as disk > > partitions. For each disk the list of slave disks is also listed and > > /dev path is us

Re: [PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-09-29 Thread Marc-André Lureau
Hi On Mon, Sep 7, 2020 at 1:17 PM Tomáš Golembiovský wrote: > The command lists all disks (real and virtual) as well as disk > partitions. For each disk the list of slave disks is also listed and > /dev path is used as a handle so it can be matched with "name" filed of > field other returned d

[PATCH v2 2/3] qga: add implementation of guest-get-disks for Linux

2020-09-07 Thread Tomáš Golembiovský
The command lists all disks (real and virtual) as well as disk partitions. For each disk the list of slave disks is also listed and /dev path is used as a handle so it can be matched with "name" filed of other returned disk entries. For disk partitions the "slave" list is populated with the the par