Re: [PATCH v2 2/3] target/arm: Implement an IMPDEF pauth algorithm

2020-08-14 Thread Richard Henderson
On 8/14/20 2:26 AM, Andrew Jones wrote: >> +static uint64_t __attribute__((noinline)) >> +pauth_computepac_impdef(uint64_t data, uint64_t modifier, ARMPACKey key) > > Out of curiosity, why do we need to make these computepac functions > noinline? Oh, heh. Left over from profiling. Will remove.

Re: [PATCH v2 2/3] target/arm: Implement an IMPDEF pauth algorithm

2020-08-14 Thread Andrew Jones
On Thu, Aug 13, 2020 at 01:02:42PM -0700, Richard Henderson wrote: > Without hardware acceleration, a cryptographically strong > algorithm is too expensive for pauth_computepac. > > Even with hardware accel, we are not currently expecting > to link the linux-user binaries to any crypto libraries,

[PATCH v2 2/3] target/arm: Implement an IMPDEF pauth algorithm

2020-08-13 Thread Richard Henderson
Without hardware acceleration, a cryptographically strong algorithm is too expensive for pauth_computepac. Even with hardware accel, we are not currently expecting to link the linux-user binaries to any crypto libraries, and doing so would generally make the --static build fail. So choose XXH64