Re: [PATCH v2 2/4] hw/gpio: add PCA9538 8-bit GPIO expander

2023-02-08 Thread Philippe Mathieu-Daudé
On 8/2/23 23:43, Titus Rwantare wrote: The 8-bit expander has different register offsets than the 16-bit one, making them incompatible. Following extract/deposit API suggestion on previous patch, an alternatively is to use PCAGPIOClass::input_port/output_port/... offset fields.

[PATCH v2 2/4] hw/gpio: add PCA9538 8-bit GPIO expander

2023-02-08 Thread Titus Rwantare
The 8-bit expander has different register offsets than the 16-bit one, making them incompatible. Reviewed-by: Hao Wu Signed-off-by: Titus Rwantare --- hw/gpio/pca_i2c_gpio.c | 94 ++ include/hw/gpio/pca_i2c_gpio.h | 7 +++ 2 files changed, 101