Re: QAPI unions as branches / unifying struct and union types (was: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command)

2023-02-10 Thread Het Gala
On 10/02/23 12:54 pm, Markus Armbruster wrote: Daniel P. Berrangé writes: [...] +## +# @MigrateAddress: +# +# The options available for communication transport mechanisms for migration +# +# Since 8.0 +## +{ 'union' : 'MigrateAddress', + 'base' : { 'transport' : 'MigrateTransport'}, + 'di

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-10 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Thu, Feb 09, 2023 at 10:23:43AM +, Daniel P. Berrangé wrote: [...] >> I don't know the backstory on this limitation. Is it something that >> is very difficult to resolve ? I think it is highly desirable to have >> 'socket': 'SocketAddress' here. It would be a

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-10 Thread Het Gala
On 09/02/23 6:52 pm, Daniel P. Berrangé wrote: On Thu, Feb 09, 2023 at 06:41:41PM +0530, Het Gala wrote: On 09/02/23 3:59 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: Existing 'migrate' QAPI design enforces transport mechanism, ip address of destina

QAPI unions as branches / unifying struct and union types (was: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command)

2023-02-09 Thread Markus Armbruster
Daniel P. Berrangé writes: [...] >> +## >> +# @MigrateAddress: >> +# >> +# The options available for communication transport mechanisms for migration >> +# >> +# Since 8.0 >> +## >> +{ 'union' : 'MigrateAddress', >> + 'base' : { 'transport' : 'MigrateTransport'}, >> + 'discriminator' : 'transp

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Het Gala
On 09/02/23 7:08 pm, Daniel P. Berrangé wrote: On Thu, Feb 09, 2023 at 10:23:43AM +, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: Existing 'migrate' QAPI design enforces transport mechanism

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Het Gala
On 09/02/23 9:56 pm, Markus Armbruster wrote: Daniel P. Berrangé writes: On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: [...] I'm guessing the reason you didn't go with 'socket': 'SocketAddress' is that SocketAddress is itself a discriminated union, and Markus does not yet ha

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: [...] >> I'm guessing the reason you didn't go with 'socket': 'SocketAddress' >> is that SocketAddress is itself a discriminated union, and Markus does >> not yet have the QAPI generator wired up to support

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Daniel P . Berrangé
On Thu, Feb 09, 2023 at 10:23:43AM +, Daniel P. Berrangé wrote: > On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: > > On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > > of destination interfac

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Daniel P . Berrangé
On Thu, Feb 09, 2023 at 06:41:41PM +0530, Het Gala wrote: > > On 09/02/23 3:59 pm, Daniel P. Berrangé wrote: > > On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > > of destination interface and corresponding

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Het Gala
On 09/02/23 3:59 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter for initiating

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Het Gala
On 09/02/23 3:53 pm, Daniel P. Berrangé wrote: On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number i

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Daniel P . Berrangé
On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: > Existing 'migrate' QAPI design enforces transport mechanism, ip address > of destination interface and corresponding port number in the form > of a unified string 'uri' parameter for initiating a migration stream. > This scheme has a signi

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-09 Thread Daniel P . Berrangé
On Wed, Feb 08, 2023 at 02:17:12PM -0600, Eric Blake wrote: > On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > of destination interface and corresponding port number in the form > > of a unified string 'uri' pa

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-08 Thread Het Gala
On 09/02/23 1:47 am, Eric Blake wrote: On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter for initiating a migra

Re: [PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-08 Thread Eric Blake
On Wed, Feb 08, 2023 at 09:35:56AM +, Het Gala wrote: > Existing 'migrate' QAPI design enforces transport mechanism, ip address > of destination interface and corresponding port number in the form > of a unified string 'uri' parameter for initiating a migration stream. > This scheme has a signi

[PATCH v2 2/6] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-02-08 Thread Het Gala
Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter for initiating a migration stream. This scheme has a significant flaw in it - double encoding of existing URIs to extract mi