Re: [PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option

2020-08-11 Thread Shu-Chun Weng
It does look like something that can be improved. The lines have been there for 14 years though: https://github.com/qemu/qemu/commit/53a5960aadd542dd27b8705ac30df154557d5ffc The potential bug is triggered when the user passes in a 2-byte integer in getsockopt(), which seems uncommon -- do we have

Re: [PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option

2020-08-11 Thread Laurent Vivier
Le 11/08/2020 à 09:09, Shu-Chun Weng a écrit : > SOL_UDP manipulate options at UDP level. All six options currently defined > in linux source include/uapi/linux/udp.h take integer values. > > Signed-off-by: Shu-Chun Weng > Reviewed-by: Laurent Vivier > --- > v1 -> v2: > Split out SOL_UDP into

[PATCH v2 2/8] linux-user: add missing UDP get/setsockopt option

2020-08-11 Thread Shu-Chun Weng
SOL_UDP manipulate options at UDP level. All six options currently defined in linux source include/uapi/linux/udp.h take integer values. Signed-off-by: Shu-Chun Weng Reviewed-by: Laurent Vivier --- v1 -> v2: Split out SOL_UDP into own patch. Updated do_print_sockopt(). linux-user/strace.c