Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-25 Thread John Snow
On 9/25/20 1:05 PM, Cleber Rosa wrote: On Wed, Sep 23, 2020 at 07:55:50PM -0400, John Snow wrote: On 9/23/20 6:36 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: J

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-25 Thread Cleber Rosa
On Wed, Sep 23, 2020 at 07:55:50PM -0400, John Snow wrote: > On 9/23/20 6:36 PM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: > > > Annotations do not change runtime behavior. > > > This commit *only* adds annotations. > > > > > > Signed-off-by: John Snow > >

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-25 Thread John Snow
On 9/25/20 8:22 AM, Markus Armbruster wrote: Worth capturing in a comment and/or commit message? Doesn't hurt me any to do so. It's also good fodder for a style guide document, which would centralize such things. Here is a formal IOU: https://gitlab.com/jsnow/qemu/-/issues/7 --js

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-25 Thread Markus Armbruster
John Snow writes: > On 9/23/20 6:36 PM, Cleber Rosa wrote: >> On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: >>> Annotations do not change runtime behavior. >>> This commit *only* adds annotations. >>> >>> Signed-off-by: John Snow [...] >>> diff --git a/scripts/qapi/source.py b/scrip

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-23 Thread John Snow
On 9/23/20 6:36 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - scripts/qapi/source.py | 31 ++--

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > --- > scripts/qapi/mypy.ini | 5 - > scripts/qapi/source.py | 31 ++- > 2 files changed

Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:45PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH v2 22/38] qapi/source.py: add type hint annotations

2020-09-22 Thread John Snow
Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow --- scripts/qapi/mypy.ini | 5 - scripts/qapi/source.py | 31 ++- 2 files changed, 18 insertions(+), 18 deletions(-) diff --git a/scripts/qapi/mypy.ini b/s