Re: [PATCH v2 23/26] target/arm/tcg: Inline 'exec/helper-gen.h'

2023-06-14 Thread Philippe Mathieu-Daudé
On 14/6/23 07:01, Richard Henderson wrote: On 6/11/23 10:58, Philippe Mathieu-Daudé wrote: +++ b/target/arm/helper.c @@ -26,6 +26,11 @@   #include "qapi/error.h"   #include "qemu/guest-random.h"   #ifdef CONFIG_TCG + +#define HELPER_H "helper.h" +#include "exec/helper-gen.h.inc" +#undef  HELPER_

Re: [PATCH v2 23/26] target/arm/tcg: Inline 'exec/helper-gen.h'

2023-06-13 Thread Richard Henderson
On 6/11/23 10:58, Philippe Mathieu-Daudé wrote: +++ b/target/arm/helper.c @@ -26,6 +26,11 @@ #include "qapi/error.h" #include "qemu/guest-random.h" #ifdef CONFIG_TCG + +#define HELPER_H "helper.h" +#include "exec/helper-gen.h.inc" +#undef HELPER_H Why is this here? helper-gen is for tc

[PATCH v2 23/26] target/arm/tcg: Inline 'exec/helper-gen.h'

2023-06-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- CHECK: By extracting some inlined (FP) helpers from translate.h, we could reduce 'helper-gen.h.inc' to helper.c. --- target/arm/tcg/translate.h | 4 +++- target/arm/helper.c| 5 + 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/t