Re: [PATCH v2 24/26] target/arm/tcg: Inline 'exec/helper-proto.h'

2023-06-14 Thread Richard Henderson
On 6/14/23 14:50, Philippe Mathieu-Daudé wrote: We get: ../../target/arm/tcg/vec_helper.c:268:6: error: no previous prototype for function 'helper_gvec_qrdmlah_s16' [-Werror,-Wmissing-prototypes] ../../target/arm/tcg/vec_helper.c:293:6: error: no previous prototype for function

Re: [PATCH v2 24/26] target/arm/tcg: Inline 'exec/helper-proto.h'

2023-06-14 Thread Philippe Mathieu-Daudé
On 14/6/23 07:03, Richard Henderson wrote: On 6/11/23 10:58, Philippe Mathieu-Daudé wrote: +++ b/target/arm/tcg/vec_helper.c @@ -19,12 +19,15 @@   #include "qemu/osdep.h"   #include "cpu.h" -#include "exec/helper-proto.h"   #include "tcg/tcg-gvec-desc.h"   #include "fpu/softfloat.h"   #include

Re: [PATCH v2 24/26] target/arm/tcg: Inline 'exec/helper-proto.h'

2023-06-13 Thread Richard Henderson
On 6/11/23 10:58, Philippe Mathieu-Daudé wrote: +++ b/target/arm/tcg/vec_helper.c @@ -19,12 +19,15 @@ #include "qemu/osdep.h" #include "cpu.h" -#include "exec/helper-proto.h" #include "tcg/tcg-gvec-desc.h" #include "fpu/softfloat.h" #include "qemu/int128.h" #include

[PATCH v2 24/26] target/arm/tcg: Inline 'exec/helper-proto.h'

2023-06-11 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- This mean we can extract more tcg/helper-foo.h.inc, maybe: - gvec / simd / crypto - exception / wfi --- target/arm/debug_helper.c | 6 +- target/arm/helper.c| 2 +- target/arm/tcg/crypto_helper.c | 5 -