Re: [PATCH v2 25/38] qapi/gen.py: add type hint annotations

2020-09-23 Thread Eduardo Habkost
On Wed, Sep 23, 2020 at 08:29:17PM -0400, John Snow wrote: > On 9/23/20 7:51 PM, Cleber Rosa wrote: > > On Tue, Sep 22, 2020 at 05:00:48PM -0400, John Snow wrote: > > > Annotations do not change runtime behavior. > > > This commit *only* adds annotations. > > > > > > Signed-off-by: John Snow > >

Re: [PATCH v2 25/38] qapi/gen.py: add type hint annotations

2020-09-23 Thread John Snow
On 9/23/20 7:51 PM, Cleber Rosa wrote: On Tue, Sep 22, 2020 at 05:00:48PM -0400, John Snow wrote: Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow --- scripts/qapi/gen.py | 102 +++- 1 file chan

Re: [PATCH v2 25/38] qapi/gen.py: add type hint annotations

2020-09-23 Thread Cleber Rosa
On Tue, Sep 22, 2020 at 05:00:48PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow > --- > scripts/qapi/gen.py | 102 +++- > 1 file changed, 53 insertions(+), 49 dele

Re: [PATCH v2 25/38] qapi/gen.py: add type hint annotations

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:48PM -0400, John Snow wrote: > Annotations do not change runtime behavior. > This commit *only* adds annotations. > > Signed-off-by: John Snow Reviewed-by: Eduardo Habkost -- Eduardo

[PATCH v2 25/38] qapi/gen.py: add type hint annotations

2020-09-22 Thread John Snow
Annotations do not change runtime behavior. This commit *only* adds annotations. Signed-off-by: John Snow --- scripts/qapi/gen.py | 102 +++- 1 file changed, 53 insertions(+), 49 deletions(-) diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index cb