Re: [PATCH v2 3/5] nbd: Simplify meta-context parsing

2020-10-07 Thread Eric Blake
On 10/7/20 6:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 30.09.2020 15:11, Eric Blake wrote: >> We had a premature optimization of trying to read as little from the >> wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. >> But in reality, we HAVE to read the entire string from the

Re: [PATCH v2 3/5] nbd: Simplify meta-context parsing

2020-10-07 Thread Vladimir Sementsov-Ogievskiy
30.09.2020 15:11, Eric Blake wrote: We had a premature optimization of trying to read as little from the wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. But in reality, we HAVE to read the entire string from the client before we can get to the next command, and it is easier to

[PATCH v2 3/5] nbd: Simplify meta-context parsing

2020-09-30 Thread Eric Blake
We had a premature optimization of trying to read as little from the wire as possible while handling NBD_OPT_SET_META_CONTEXT in phases. But in reality, we HAVE to read the entire string from the client before we can get to the next command, and it is easier to just read it all at once than it is t