Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2021-01-07 Thread Peter Maydell
On Thu, 17 Dec 2020 at 12:24, Leif Lindholm wrote: > > On Thu, Dec 17, 2020 at 13:18:03 +0100, Laurent Desnogues wrote: > > I was thinking about changing the field names, not the register name > > because the register is the same, only the layout changes. So > > LINESIZE -> CCIDX_LINESIZE, etc. >

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Leif Lindholm
On Thu, Dec 17, 2020 at 13:18:03 +0100, Laurent Desnogues wrote: > On Thu, Dec 17, 2020 at 1:10 PM Leif Lindholm wrote: > [...] > > > > > > +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) > > > > > > +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 21) > > > > > > +FIELD(CCSIDR_EL1, NUMSETS, 32, 24) > > > > > > > > > > Th

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Laurent Desnogues
On Thu, Dec 17, 2020 at 1:10 PM Leif Lindholm wrote: [...] > > > > > +FIELD(CCSIDR_EL1, LINESIZE, 0, 3) > > > > > +FIELD(CCSIDR_EL1, ASSOCIATIVITY, 3, 21) > > > > > +FIELD(CCSIDR_EL1, NUMSETS, 32, 24) > > > > > > > > The positions and sizes of the ASSOCIATIVITY and NUMSETS CCSIDR fields > > > > de

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Leif Lindholm
Hi Laurent, On Thu, Dec 17, 2020 at 11:02:23 +0100, Laurent Desnogues wrote: > Hi Leif, > > On Tue, Dec 15, 2020 at 5:49 PM Leif Lindholm wrote: > > > > On Tue, Dec 15, 2020 at 13:23:58 +0100, Laurent Desnogues wrote: > > > Hello, > > > > > > On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-17 Thread Laurent Desnogues
Hi Leif, On Tue, Dec 15, 2020 at 5:49 PM Leif Lindholm wrote: > > On Tue, Dec 15, 2020 at 13:23:58 +0100, Laurent Desnogues wrote: > > Hello, > > > > On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > > > > > Signed-off-by: Leif Lindholm > > > --- > > > target/arm/cpu.h | 24 +++

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Leif Lindholm
On Tue, Dec 15, 2020 at 13:23:58 +0100, Laurent Desnogues wrote: > Hello, > > On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > > > Signed-off-by: Leif Lindholm > > --- > > target/arm/cpu.h | 24 > > 1 file changed, 24 insertions(+) > > > > diff --git a/target/a

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Laurent Desnogues
Hello, On Tue, Dec 15, 2020 at 12:51 PM Leif Lindholm wrote: > > Signed-off-by: Leif Lindholm > --- > target/arm/cpu.h | 24 > 1 file changed, 24 insertions(+) > > diff --git a/target/arm/cpu.h b/target/arm/cpu.h > index fadd1a47df..90ba707b64 100644 > --- a/target/arm/

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Leif Lindholm
On Mon, Dec 14, 2020 at 13:36:51 +, Peter Maydell wrote: > On Mon, 14 Dec 2020 at 12:36, Leif Lindholm wrote: > > > > Signed-off-by: Leif Lindholm > > --- > > v1->v2: > > - Correct CCSIDR_EL1 field sizes. > > Hi -- could you resend the whole series for a v2, please? > The tools (and people)

[PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-15 Thread Leif Lindholm
Signed-off-by: Leif Lindholm --- target/arm/cpu.h | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index fadd1a47df..90ba707b64 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1736,6 +1736,30 @@ FIELD(V7M_FPCCR, ASPEN, 31,

Re: [PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-14 Thread Peter Maydell
On Mon, 14 Dec 2020 at 12:36, Leif Lindholm wrote: > > Signed-off-by: Leif Lindholm > --- > v1->v2: > - Correct CCSIDR_EL1 field sizes. Hi -- could you resend the whole series for a v2, please? The tools (and people) that handle patches get a bit confused by partial series. thanks -- PMM

[PATCH v2 3/5] target/arm: add descriptions of CLIDR_EL1, CCSIDR_EL1, CTR_EL0 to cpu.h

2020-12-14 Thread Leif Lindholm
Signed-off-by: Leif Lindholm --- v1->v2: - Correct CCSIDR_EL1 field sizes. target/arm/cpu.h | 24 1 file changed, 24 insertions(+) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index fadd1a47df..90ba707b64 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1736