Re: [PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc

2020-03-22 Thread Philippe Mathieu-Daudé
On 3/19/20 8:33 PM, Peter Maydell wrote: All the Coverity-specific definitions of qemu_mutex_lock() and friends have a trailing semicolon. This works fine almost everywhere because of QEMU's mandatory-braces coding style and because most callsites are simple, but target/s390x/sigp.c has a use of

Re: [PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc

2020-03-20 Thread Richard Henderson
On 3/19/20 12:33 PM, Peter Maydell wrote: > All the Coverity-specific definitions of qemu_mutex_lock() and friends > have a trailing semicolon. This works fine almost everywhere because > of QEMU's mandatory-braces coding style and because most callsites are > simple, but target/s390x/sigp.c has a

[PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc

2020-03-19 Thread Peter Maydell
All the Coverity-specific definitions of qemu_mutex_lock() and friends have a trailing semicolon. This works fine almost everywhere because of QEMU's mandatory-braces coding style and because most callsites are simple, but target/s390x/sigp.c has a use of qemu_mutex_trylock() as an if() statement,