On Wed, Sep 23, 2020 at 05:43:45PM -0400, John Snow wrote:
> On 9/23/20 12:35 PM, Eduardo Habkost wrote:
> > I believe these two lines above should be removed, as suggested
> > in patch 30, but let's ignore that for now.
> >
>
> Yup, headed there.
>
> > > -if features:
> > > -obj['fe
On 9/23/20 12:35 PM, Eduardo Habkost wrote:
I believe these two lines above should be removed, as suggested
in patch 30, but let's ignore that for now.
Yup, headed there.
-if features:
-obj['features'] = [(f.name, Extra(None, f.ifcond)) for f in features]
I can't say I understan
On Tue, Sep 22, 2020 at 05:00:54PM -0400, John Snow wrote:
> _make_tree doesn't know if it is receiving an object or some other type;
> adding features information should arguably be performed by the caller.
>
> This will help us refactor _make_tree more gracefully in the next patch.
>
> Signed-o
_make_tree doesn't know if it is receiving an object or some other type;
adding features information should arguably be performed by the caller.
This will help us refactor _make_tree more gracefully in the next patch.
Signed-off-by: John Snow
---
scripts/qapi/introspect.py | 22 ++--
