Re: [PATCH v2 32/38] qapi/introspect.py: create a typed 'Node' data structure

2020-09-23 Thread John Snow
On 9/23/20 2:41 PM, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:00:55PM -0400, John Snow wrote: Replacing the un-typed tuple, add a typed Node that we can add typed metadata to. Signed-off-by: John Snow This is the most complex patch so far, and it's very hard to understand what it doe

Re: [PATCH v2 32/38] qapi/introspect.py: create a typed 'Node' data structure

2020-09-23 Thread John Snow
On 9/23/20 2:41 PM, Eduardo Habkost wrote: On Tue, Sep 22, 2020 at 05:00:55PM -0400, John Snow wrote: Replacing the un-typed tuple, add a typed Node that we can add typed metadata to. Signed-off-by: John Snow This is the most complex patch so far, and it's very hard to understand what it doe

Re: [PATCH v2 32/38] qapi/introspect.py: create a typed 'Node' data structure

2020-09-23 Thread Eduardo Habkost
On Tue, Sep 22, 2020 at 05:00:55PM -0400, John Snow wrote: > Replacing the un-typed tuple, add a typed Node that we can add typed > metadata to. > > Signed-off-by: John Snow This is the most complex patch so far, and it's very hard to understand what it does without type annotations. Have you c

[PATCH v2 32/38] qapi/introspect.py: create a typed 'Node' data structure

2020-09-22 Thread John Snow
Replacing the un-typed tuple, add a typed Node that we can add typed metadata to. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 53 -- 1 file changed, 28 insertions(+), 25 deletions(-) diff --git a/scripts/qapi/introspect.py b/scripts/qapi/introsp