Re: [PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-22 Thread Claudio Fontana
Apologies, already reviewed, will ping for the merge of the series momentarily, Claudio On 8/22/23 14:18, Claudio Fontana wrote: > Hello, > > this patch would still need a review, > > and is needed as a precondition for further work to improve dramatically the > performance of virsh save, virs

Re: [PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-22 Thread Claudio Fontana
Hello, this patch would still need a review, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, since Peter Xu already reviewed PATCH 1, 2, 3, maybe it makes sense to look at 4 too? Thanks, Claudio On

Re: [PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-16 Thread Peter Xu
On Wed, Aug 16, 2023 at 03:28:17PM -0300, Fabiano Rosas wrote: > We don't need to do this in two pieces. One single function makes it > easier to grasp, specially since it removes the indirection on the > return value handling. > > Signed-off-by: Fabiano Rosas Reviewed-by: Peter Xu -- Peter X

[PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-16 Thread Fabiano Rosas
We don't need to do this in two pieces. One single function makes it easier to grasp, specially since it removes the indirection on the return value handling. Signed-off-by: Fabiano Rosas --- migration/ram.c | 46 +- 1 file changed, 13 insertions(+), 3