Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Samuel Thibault
Joelle van Dyne, le mar. 09 mars 2021 10:11:31 -0800, a ecrit: > On Tue, Mar 9, 2021 at 6:09 AM Philippe Mathieu-Daudé > wrote: > > On 3/9/21 1:27 AM, Joelle van Dyne wrote: > > > Replace Windows specific macro with a more generic feature detection > > > macro. Allows slirp smb feature to be

Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Joelle van Dyne
On Tue, Mar 9, 2021 at 6:09 AM Philippe Mathieu-Daudé wrote: > > Hi Joelle, > > On 3/9/21 1:27 AM, Joelle van Dyne wrote: > > Replace Windows specific macro with a more generic feature detection > > macro. Allows slirp smb feature to be disabled manually as well. > > > > Signed-off-by: Joelle van

Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Philippe Mathieu-Daudé
Hi Joelle, On 3/9/21 1:27 AM, Joelle van Dyne wrote: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- > configure | 26 +++--- > meson.build |

Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Philippe Mathieu-Daudé
On 3/9/21 1:27 AM, Joelle van Dyne wrote: > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 26

Re: [PATCH v2 4/4] slirp: feature detection for smbd

2021-03-09 Thread Peter Maydell
On Tue, 9 Mar 2021 at 00:30, Joelle van Dyne wrote: > > Replace Windows specific macro with a more generic feature detection > macro. Allows slirp smb feature to be disabled manually as well. > > Signed-off-by: Joelle van Dyne > --- Reviewed-by: Peter Maydell thanks -- PMM

[PATCH v2 4/4] slirp: feature detection for smbd

2021-03-08 Thread Joelle van Dyne
Replace Windows specific macro with a more generic feature detection macro. Allows slirp smb feature to be disabled manually as well. Signed-off-by: Joelle van Dyne --- configure | 26 +++--- meson.build | 2 +- net/slirp.c | 16 3 files changed, 32