Re: [PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-29 Thread Nicholas Piggin
On Wed Jun 28, 2023 at 7:38 PM AEST, Richard Henderson wrote: > On 6/27/23 15:46, Nicholas Piggin wrote: > > +DEF_HELPER_1(attn, void, env) > > s/void/noreturn/ Thank you x2, agree. Thanks, Nick

Re: [PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-28 Thread Richard Henderson
On 6/27/23 15:46, Nicholas Piggin wrote: +DEF_HELPER_1(attn, void, env) s/void/noreturn/ r~

Re: [PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-28 Thread Richard Henderson
On 6/27/23 15:46, Nicholas Piggin wrote: +if (env->spr[SPR_HID0] & hid0_attn) { +powerpc_checkstop(env, "host executed attn"); +cpu_loop_exit_noexc(cs); checkstop already does the cpu_loop_exit_noexc. r~

Re: [PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-27 Thread Nicholas Piggin
On Wed Jun 28, 2023 at 1:25 AM AEST, Fabiano Rosas wrote: > Nicholas Piggin writes: > > > attn is an implementation-specific instruction that on POWER (and G5/ > > 970) can be enabled with a HID bit (disabled = illegal), and executing > > it causes the host processor to stop and the service

Re: [PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-27 Thread Fabiano Rosas
Nicholas Piggin writes: > attn is an implementation-specific instruction that on POWER (and G5/ > 970) can be enabled with a HID bit (disabled = illegal), and executing > it causes the host processor to stop and the service processor to be > notified. Generally used for debugging. > > Implement

[PATCH v2 4/4] target/ppc: Implement attn instruction on BookS 64-bit processors

2023-06-27 Thread Nicholas Piggin
attn is an implementation-specific instruction that on POWER (and G5/ 970) can be enabled with a HID bit (disabled = illegal), and executing it causes the host processor to stop and the service processor to be notified. Generally used for debugging. Implement attn and make it checkstop the